Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mention of XML support to RESTful binary sensor #32582

Closed
wants to merge 11 commits into from
Closed

Add mention of XML support to RESTful binary sensor #32582

wants to merge 11 commits into from

Conversation

2sheds
Copy link
Contributor

@2sheds 2sheds commented May 3, 2024 •
edited
Loading

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Kane610 and others added 10 commits May 2, 2024 09:39
@Kane610
Remove references to UniFi WLAN password sensor (home-assistant#32556)
e1c5c3a
@Thomas55555 @frenck
Squash commits, remove merge (home-assistant#32465)
1024b12 
Co-authored-by: Franck Nijhof <[email protected]>
@aviadlevy
Better describing the question mark in regex (home-assistant#32558)
477ccd0
@googanhiem
2024.5: Correct Energenie in release notes (home-assistant#32563)
3efee4d
@frenck
Revert "Remove references to UniFi WLAN password sensor (home-assista…
91fc6c4 
…nt#32556)" (home-assistant#32564)

This reverts commit e1c5c3a.
@c0ffeeca7
HA OS installation: add note on internet access (home-assistant#32552)
bcb0f6f
@paull27
Update nina.markdown (home-assistant#32580)
c2b6d2f
@dependabot
Bump sorbet-runtime from 0.5.11367 to 0.5.11368 (home-assistant#32578)
363b785 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@koopee @frenck
Update python_script.markdown (home-assistant#32579)
75463f1 
Co-authored-by: Franck Nijhof <[email protected]>
@2sheds
Add mention of XML support to binary_sensor.rest integration
058b726
@home-assistant home-assistant bot added the current This PR goes into the current branch label May 3, 2024
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 872acdb
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6634e465d08b970008631a1b
😎 Deploy Preview https://deploy-preview-32582--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 3, 2024
@home-assistant
Copy link

home-assistant bot commented May 3, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@2sheds 2sheds mentioned this pull request May 3, 2024
Merged
20 tasks
@2sheds 2sheds changed the base branch from current to next May 3, 2024 13:19
@home-assistant home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 3, 2024
@home-assistant home-assistant bot added the next This PR goes into the next branch label May 3, 2024
@frenck frenck added the parent-merged The parent PR has been merged already label May 30, 2024
c0ffeeca7
c0ffeeca7 reviewed Jun 3, 2024
View reviewed changes
Gemfile.lock
@@ -135,7 +135,7 @@ GEM
rack-protection (= 4.0.0)
rack-session (>= 2.0.0, < 3)
tilt (~> 2.0)
sorbet-runtime (0.5.11367)
sorbet-runtime (0.5.11368)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the changes to this file. They are unrelated to the PR.

@c0ffeeca7
Copy link
Contributor

It seems a few changes sneaked into this PR that are unrelated to the XML support. Please remove those and make separate PRs for those changes. See the guidelines on creating a PR.

@2sheds
Copy link
Contributor Author

2sheds commented Jun 4, 2024

Closing to replace with #33073

@2sheds 2sheds closed this Jun 4, 2024
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 4, 2024
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Jun 4, 2024
@2sheds 2sheds deleted the patch-1 branch June 4, 2024 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 left review comments

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@2sheds @c0ffeeca7 @frenck @Kane610 @Thomas55555 @aviadlevy @googanhiem @paull27 @koopee